Skip to content

Commit

Permalink
revert change to webui-user.bat
Browse files Browse the repository at this point in the history
  • Loading branch information
AUTOMATIC1111 committed Nov 19, 2022
1 parent 3596af0 commit 47a44c7
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion webui-user.bat
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,5 @@ set PYTHON=
set GIT=
set VENV_DIR=
set COMMANDLINE_ARGS=
set ACCELERATE=

This comment has been minimized.

Copy link
@MILAD0828

MILAD0828 Nov 1, 2023

COMMANDLINE_ARGS="--skip-torch-cuda-test"


call webui.bat

7 comments on commit 47a44c7

@aliencaocao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we use the accelerate launch then?

@nightkall
Copy link

@nightkall nightkall commented on 47a44c7 Nov 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we use the accelerate launch then?

I searched ACCELERATE and I think he didn't change any of the accelerate commit changes. Merge.
So I think that you have to uncomment webui-user.sh line 44 and adding back set ACCELERATE="True" to webui-user.bat.

What I don't know exactly is what 'accelerate' does.
If I'm not mistaken it seems to be something about improving the efficiency and memory consumption of inference and training by single/multiple GPU, TPU, mixed-precision... but I'm not sure. Here is the pull discussion.

@aliencaocao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding back set ACCELERATE="True" to webui-user.bat

Well if I have to basically revert this change then that's a reason to ask why this change was made in the first place.

@TripleKiller666
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding back set ACCELERATE="True" to webui-user.bat

Well if I have to basically revert this change then that's a reason to ask why this change was made in the first place.

you can read about what accelerate does here:
https://huggingface.co/docs/accelerate/index

@aliencaocao
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can read about what accelerate does here: https://huggingface.co/docs/accelerate/index

You do not answer my question...I know what accelerate does, but I am questioning why the SET accelerate is being removed from webui-user.bat in this commit

@d8ahazard
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can read about what accelerate does here: https://huggingface.co/docs/accelerate/index

You do not answer my question...I know what accelerate does, but I am questioning why the SET accelerate is being removed from webui-user.bat in this commit

@AUTOMATIC1111 - This illustrates a glaring issue with the webui-user scripts that's bugged me for a while, and which intersects neatly with the discussion you and I were having.

IMHO, we (the developers) should be able to update webui-user files (or some other file), and that will get pushed out as a template for new installations. Maybe make a folder called "templates" or 'scripts" and chuck them in there. On an initial launch, the template scripts get copied to their usual location, but now they're ignored by .git.

This way, we have a one-way system of only updating the user scripts if needed, but also prevent git from whinging on about some change in the webui-user file made by the user. I know I find it irritating as hell that I can't ever keep any command line args in my repo because I'm always pulling from upstream, which doesn't like the changed files.

So, the right way to fix this and "not touch" the webui-user scripts would be to have them created by "something else", and then have them ignored by git.

@htakhtak
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello
What should be done to solve the following problem? please guide me .

RuntimeError: Torch is not able to use GPU; add --skip-torch-cuda-test to COMMANDLINE_ARGS variable to disable this check

Please sign in to comment.