Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Metadata records 0.4 HRF denoise strength even though it is set to 0.2 when used with ADetailer #15023

Closed
2 of 6 tasks
nickion opened this issue Feb 25, 2024 · 3 comments
Labels
bug Report of a confirmed bug upstream Issue or feature that must be resolved upstream

Comments

@nickion
Copy link

nickion commented Feb 25, 2024

Checklist

  • The issue exists after disabling all extensions
  • The issue exists on a clean installation of webui
  • The issue is caused by an extension, but I believe it is caused by a bug in the webui
  • The issue exists in the current version of the webui
  • The issue has not been reported before recently
  • The issue has been reported before but has not been fixed yet

What happened?

Using version: [v1.7.0-542-g9c65640c] but also an earlier dev version, I'm finding the denoise strength is recorded as 0.4 (the default) even though it is set to 0.2 in the UI. Confirmed with both PNG Info and Infinite Browsing ext. This is unfortunate as it impairs reproducibility.

Steps to reproduce the problem

Generate an image with denoising != 0.4 and check metadata.

What should have happened?

The correct value should be stored.

What browsers do you use to access the UI ?

No response

Sysinfo

N/A

Console logs

N/A

Additional information

No response

@nickion nickion added the bug-report Report of a bug, yet to be confirmed label Feb 25, 2024
@nickion
Copy link
Author

nickion commented Feb 25, 2024

Further digging suggests that the recorded denoise value is being taken from the ADetailer denoise value, as changing ADetailer denosing to 0.3 then records 0.3 for both denoising strength and ADetailer denosing strength. Conceivably this could therefore be an ADetailer bug, though not necessarily.

@catboxanon catboxanon added bug Report of a confirmed bug and removed bug-report Report of a bug, yet to be confirmed labels Feb 26, 2024
@catboxanon catboxanon changed the title [Bug]: Metadata records 0.4 HRF denoise strength even though it is set to 0.2 [Bug]: Metadata records 0.4 HRF denoise strength even though it is set to 0.2 when used with ADetailer Feb 26, 2024
@catboxanon catboxanon added the upstream Issue or feature that must be resolved upstream label Feb 26, 2024
@catboxanon
Copy link
Collaborator

Bing-su/adetailer#552

@catboxanon
Copy link
Collaborator

Fixed in Bing-su/adetailer#569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Report of a confirmed bug upstream Issue or feature that must be resolved upstream
Projects
None yet
Development

No branches or pull requests

2 participants