Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extra parameter error from #552 #569

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Fix extra parameter error from #552 #569

merged 1 commit into from
Apr 9, 2024

Conversation

Nakadun
Copy link
Contributor

@Nakadun Nakadun commented Apr 9, 2024

Fixes #552

I tracked down the problem, at least partially and found out that deepcopying the extra parameters in the inner loop of postprocessing does the trick.

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Apr 9, 2024
Copy link

sonarqubecloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Bing-su Bing-su changed the base branch from main to dev April 9, 2024 07:49
@Bing-su
Copy link
Owner

Bing-su commented Apr 9, 2024

Oh my python 😭. I never would have thought it was caused by referencing an object.
Probably you don't need to use deepcopy, and you don't need to copy it every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: hires.fix denoising strength always saved as 0.4 value in image metadata if ADetailer is active
2 participants