Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add/modify CFG callbacks for Self-Attention Guidance extension #10357

Merged
merged 2 commits into from
May 14, 2023

Conversation

catboxanon
Copy link
Collaborator

@catboxanon catboxanon commented May 14, 2023

Describe what this pull request is trying to achieve.

Adds/modifies CFG callbacks, required by the Self-Attention Guidance extension. https://github.com/ashen-sensored/sd_webui_SAG

Additional notes and description of your changes

Based on the patch here: https://github.com/ashen-sensored/sd_webui_SAG/blob/main/automatic1111-CFGDenoiser-and-script_callbacks-mod-for-SAG.patch
Extension author has not submitted the patch for this repo in nearly a month, so I'm doing it on behalf of them. If you would like to submit this PR yourself @ashen-sensored / @gitadmin0608, feel free.

Environment this was tested in

List the environment you have developed / tested this on. As per the contributing page, changes should be able to work on Windows out of the box.

  • OS: Windows 11
  • Browser: Firefox
  • Graphics card: NVIDIA RTX 3090

@AUTOMATIC1111
Copy link
Owner

why is there a need for output_altered flag?

@Sakura-Luna
Copy link
Collaborator

Modified the code comments according to another PR from the original author.

@AUTOMATIC1111 AUTOMATIC1111 merged commit cb9a3a7 into AUTOMATIC1111:dev May 14, 2023
@AUTOMATIC1111
Copy link
Owner

I made some changes, extension still seems to work.
Don't nkow why the inner_model parameter was added. You are supposed to refer to it using shared.sh_model.

@alenknight
Copy link

trying dev out now... seems to work. love this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants