Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gradio to 3.32 #10623

Merged
merged 1 commit into from
May 22, 2023
Merged

Bump gradio to 3.32 #10623

merged 1 commit into from
May 22, 2023

Conversation

akx
Copy link
Collaborator

@akx akx commented May 22, 2023

Describe what this pull request is trying to achieve.

Upgrades Gradio to be able to remove the docs URL hack.

Environment this was tested in

  • OS: macOS
  • Browser: Chrome
  • Graphics card: M2

Screenshots or videos of your changes

yep it's 3.32

Screenshot 2023-05-22 at 10 43 43

yep them's the docs

Screenshot 2023-05-22 at 10 43 50

@akx akx requested a review from AUTOMATIC1111 as a code owner May 22, 2023 07:45
@AUTOMATIC1111
Copy link
Owner

it's a funny thing now that this was added in gradio and we can remove the hack, but there is another improvement that would probably require the same hack - if you launch with --gradio-debug, shared.demo.launch does not return and none of api endpoints are added.

@akx
Copy link
Collaborator Author

akx commented May 22, 2023

Well, I mean, --gradio-debug sets launch(debug=True, ...) which is documented like this:

debug: if True, blocks the main thread from running. [...]

@AUTOMATIC1111 AUTOMATIC1111 merged commit 809001f into AUTOMATIC1111:dev May 22, 2023
@akx akx mentioned this pull request May 28, 2023
1 task
@akx akx deleted the bump-gradio branch May 30, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants