Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upscaler model loading cleanup #10823

Merged
merged 5 commits into from
Jun 27, 2023
Merged

Conversation

akx
Copy link
Collaborator

@akx akx commented May 29, 2023

A summary of changes in code

  • drop the dependency on basicsr for downloading stuff, make its arguments explicit (it just wrapped torch.hub anyhow)
  • clean up some pretty suspicious URL handling (and mark a couple TODOs for a bit later)
  • use exceptions, not "lol return None" for error handling

"a bit later" refers to some future work to clean up some of the upscaler stuff which is a bit baroque atm.

Tested:

  • ScuNET upscaling in HR fix
  • SwinIR upscaling in HR fix
  • Real-ESRGAN upscaling in HR fix
  • LDSR upscaling in HR fix

Checklist:

@akx akx force-pushed the model-loady branch 2 times, most recently from 6ff89f4 to 6c6ba44 Compare May 29, 2023 07:57
@akx akx marked this pull request as ready for review June 13, 2023 10:04
@akx akx requested a review from AUTOMATIC1111 as a code owner June 13, 2023 10:04
@AUTOMATIC1111 AUTOMATIC1111 merged commit 3cd4fd5 into AUTOMATIC1111:dev Jun 27, 2023
@akx akx deleted the model-loady branch June 27, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants