persistent conds cache #11087
Merged
persistent conds cache #11087
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
make conds cache persistent across jobs
seems to work fine during testing
tested on 3090 and a 1650 with --lowvram
on a low end card it has a potential of saving one to two 1~2 seconds per job
I implemented it as opt-in experimental option for now, because that I'm unsure if there are any extension that misses around with conds
other changes
it seems to me that
StableDiffusionProcessingTxt2Img.close()is missing thesuper().close()be honest I'm not entirely sure what the close is for, I don't see the need of clearing those objects, maybe I'm missing something
Checklist: