Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some deprecated types #12846

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Fix some deprecated types #12846

merged 1 commit into from
Sep 9, 2023

Conversation

a666
Copy link
Contributor

@a666 a666 commented Aug 29, 2023

Description

Several python types from the typing module have been deprecated, this commit updates them.

Screenshots/videos:

None needed.

Checklist:

@a666 a666 requested a review from AUTOMATIC1111 as a code owner August 29, 2023 08:23
@AUTOMATIC1111
Copy link
Owner

will it work on python 3.9?

@a666
Copy link
Contributor Author

a666 commented Aug 29, 2023

I don't see why it wouldn't, python 3.9 typing examples in the oficial documentation are explicitly written in that form.

@AUTOMATIC1111 AUTOMATIC1111 merged commit 9246423 into AUTOMATIC1111:dev Sep 9, 2023
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
Closed
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@a666 @AUTOMATIC1111