Interrupt after current generation #13653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antfu
commented
Oct 16, 2023
| @@ -113,6 +113,7 @@ | |||
| "disable_mmap_load_safetensors": OptionInfo(False, "Disable memmapping for loading .safetensors files.").info("fixes very slow loading speed in some cases"), | |||
| "hide_ldm_prints": OptionInfo(True, "Prevent Stability-AI's ldm/sgm modules from printing noise to console."), | |||
| "dump_stacks_on_signal": OptionInfo(False, "Print stack traces before exiting the program with ctrl+c."), | |||
| "interrupt_after_current": OptionInfo(False, "Interrupt generation after current image is finished on batch processing"), | |||
There was a problem hiding this comment.
Default to False for now, to avoid behavior changes.
But honestly, I personally would have this always on. Would you consider making it default to true?
antfu
commented
Oct 16, 2023
modules/ui.py
Outdated
| @@ -216,8 +216,14 @@ def __init__(self, is_img2img): | |||
| outputs=[], | |||
| ) | |||
|
|
|||
| def interrupt_fn(): | |||
| if shared.state.job_count > 1 and shared.opts.interrupt_after_current: | |||
There was a problem hiding this comment.
About the self.job_count > 1 condition, I think that's the intuitive behavior that:
- Interrupt right away when generating single image
- Interrupt on next when doing batch
- To interrupt right away in batch, the user could do "Interrupt" and then "Skip".
|
I think this can be done without adding |
AUTOMATIC1111
approved these changes
Jan 1, 2024
AUTOMATIC1111
added a commit
that referenced
this pull request
Jan 1, 2024
…setting default to true for #13653
1 task
Closed
Closed
ruchej
pushed a commit
to ruchej/stable-diffusion-webui
that referenced
this pull request
Sep 30, 2024
…setting default to true for AUTOMATIC1111#13653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolves #7488, resolves #8898
And an option (in the System tab) to Interrupt after the current generation when doing batch.
Alternative
Screenshots/videos:
Screen.Recording.2023-10-16.at.14.14.40.mov
Checklist: