-
Notifications
You must be signed in to change notification settings - Fork 27.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added accordion settings options #13826
added accordion settings options #13826
Conversation
Edit: changed the nested with to single line so that subsequent lines retain the same amount of tabs as before. Makes looking at the changed files a lot cleaner. @AUTOMATIC1111 Could you take a look? |
48a7933
to
5432d93
Compare
hmm need a |
oh wow, what embarrassing mistakes. Changed to using contextlib.ExitStack as an alternative to suppress |
3a4a6c4
to
28b8bb1
Compare
I'm not sure that adding a |
I suppose it doesn't really make a difference |
yeah that makes sense, thanks for catching the issue! My bad for not doing enough testing after changing it from nested with statements to single line. |
28b8bb1
to
3432284
Compare
3432284
to
3a4a6c4
Compare
my opinion on this PR
note I don't use webui on mobel |
@AUTOMATIC1111 If you could please take a look at some point |
@ezxzeng please just be patient AUTO's probably taking a break I wouldn't him ping if it isn't urgent (ping most likely gets buried anyway) he will eventually gets to PR's |
ah okay, I just wasn't sure what the normal response time is like |
Description
Screenshots/videos:
Checklist: