Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added accordion settings options #13826

Merged
merged 7 commits into from
Nov 19, 2023
Merged

added accordion settings options #13826

merged 7 commits into from
Nov 19, 2023

Conversation

ezxzeng
Copy link
Contributor

@ezxzeng ezxzeng commented Nov 3, 2023 •
edited
Loading

Description

  • Added an accordion layout for txt2img settings so that it can be toggled closed.
  • Main purpose is to make sure I don't accidentally change settings when scrolling up and down between input and results when on mobile

Screenshots/videos:

Screenshot from 2023-11-02 22-09-05

Checklist:

@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 9, 2023

Edit: changed the nested with to single line so that subsequent lines retain the same amount of tabs as before. Makes looking at the changed files a lot cleaner.

@AUTOMATIC1111 Could you take a look?

w-e-w
w-e-w requested changes Nov 10, 2023
View reviewed changes
modules/ui.py Outdated Show resolved Hide resolved
modules/ui.py Outdated Show resolved Hide resolved
@w-e-w
Copy link
Collaborator

w-e-w commented Nov 10, 2023

hmm need a suppress() alternative

@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 10, 2023 •
edited
Loading

oh wow, what embarrassing mistakes. Changed to using contextlib.ExitStack as an alternative to suppress

@ezxzeng ezxzeng requested a review from w-e-w November 10, 2023 21:07
@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 10, 2023

I'm not sure that adding a null_context_manager would be a better solution. Could you take a look at the comparison?

@w-e-w
Copy link
Collaborator

w-e-w commented Nov 10, 2023

I suppose it doesn't really make a difference
was a bit confused because I was amending my commit

@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 10, 2023

yeah that makes sense, thanks for catching the issue! My bad for not doing enough testing after changing it from nested with statements to single line.

@w-e-w
Copy link
Collaborator

w-e-w commented Nov 10, 2023 •
edited
Loading

my opinion on this PR
as long as this doesn't cause any extension compatibility issues I have no objections with this PR

and from my brief testing it seems fine

note I don't use webui on mobel

@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 17, 2023

@AUTOMATIC1111 If you could please take a look at some point

@w-e-w
Copy link
Collaborator

w-e-w commented Nov 17, 2023

@ezxzeng please just be patient AUTO's probably taking a break I wouldn't him ping if it isn't urgent (ping most likely gets buried anyway) he will eventually gets to PR's

@ezxzeng
Copy link
Contributor Author

ezxzeng commented Nov 17, 2023

ah okay, I just wasn't sure what the normal response time is like

@AUTOMATIC1111 AUTOMATIC1111 merged commit 6429c3d into AUTOMATIC1111:dev Nov 19, 2023
6 checks passed
@ezxzeng ezxzeng deleted the ui_mobile_optimizations branch November 21, 2023 19:47
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
Closed
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

@w-e-w w-e-w w-e-w approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ezxzeng @w-e-w @AUTOMATIC1111