Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move exception_records related methods to errors.py #14084

Merged
merged 2 commits into from
Nov 26, 2023
Merged

Move exception_records related methods to errors.py #14084

merged 2 commits into from
Nov 26, 2023

Conversation

wfjsw
Copy link
Contributor

@wfjsw wfjsw commented Nov 24, 2023

Description

  • Move exception_records related methods to errors.py
  • Putting all getters and setters of a file into another file makes no sense and would cause problems
  • Fixes circular dependency problem when errors happen in shared.py

Screenshots/videos:

639df9b4f3f2af2cd2db1cfe28356f91

Checklist:

@AUTOMATIC1111 AUTOMATIC1111 merged commit f7f015e into AUTOMATIC1111:dev Nov 26, 2023
3 checks passed
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
Closed
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AUTOMATIC1111 AUTOMATIC1111 AUTOMATIC1111 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wfjsw @AUTOMATIC1111