Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix not able to exit metadata popup when pop up is too big #14156

Merged
merged 2 commits into from
Dec 2, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Nov 30, 2023

Description

sometime the extra network cards metadata pop up can be too big as to take up the entire screen
when this happened it is not possible to exit the metadata pop up

solution
add max-height: 90%; and max-width: 90%; .global-popup-inner
this prevents the pop-up from being too big as to making exiting the pop-up impossible

this is what I came up with using my limited web development knowledge

Screenshots/videos:

2023-12-01.03_02_53_999.chrome.mp4

Checklist:

prevent the pop-up from being too big as to making exiting the pop-up impossible
@w-e-w w-e-w requested a review from AUTOMATIC1111 as a code owner November 30, 2023 18:13
@missionfloyd
Copy link
Collaborator

How about using Escape?

window.addEventListener("keydown", function(event) {
    if (event.key == "Escape") {
        closePopup();
    }
});

@w-e-w
Copy link
Collaborator Author

w-e-w commented Dec 1, 2023

How about using Escape?

does escape work for mobile?

@missionfloyd
Copy link
Collaborator

missionfloyd commented Dec 1, 2023

Not without a keyboard. I mean in addition to your solution. The image viewer closes with escape, so might as well do it for the other popups.

case "Escape":
closeModal();

@w-e-w
Copy link
Collaborator Author

w-e-w commented Dec 1, 2023

I mean in addition to your solution

ahh, no objection, all for it in fact it make sense.

I think you can push to this PR, unless you wanted me to do it?

@AUTOMATIC1111 AUTOMATIC1111 merged commit 600036d into dev Dec 2, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the metadata-pop-up-size-limit branch December 2, 2023 06:30
@w-e-w w-e-w mentioned this pull request Dec 4, 2023
@w-e-w w-e-w mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants