Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

on mouse hover show / hide modal image viewer icons #14291

Merged

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 12, 2023

Description

future request #14288 Fullscreen Preview control fading/disable.

  • for mouse usere, show and hide fullscreen image viewer icon on mouse hover

  • this CSS is only in effect when using Mouse, so mobile are not affected

personally I think it looks better when it's automatically hidden
but ideally they should be an option to toggle this behavior, currently I haven't figured out how to do so

demo video

2023-12-13.01_59_20_248.chrome.mp4

Checklist:

@jefferysanders
Copy link

Perfect thanks!

@AUTOMATIC1111
Copy link
Owner

For a user who doesn't know about those elements at top it could be difficult to find out about them if they are invisible. Maybe a setting toggle?

@w-e-w
Copy link
Collaborator Author

w-e-w commented Dec 15, 2023

I implemented a strange method of making it optional
and also add an option to configure the opacity of the entire top toolbar
I couldn't find a more elegant method of making a certain css rule optional
any advice?

@akx
Copy link
Collaborator

akx commented Dec 15, 2023

I implemented a strange method

I think a CSS variable is absolutely fine for this 👍

@AUTOMATIC1111 AUTOMATIC1111 merged commit 15156cd into dev Jan 1, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the on-mouse-hover-show-hide-modal-image-viewer-icons branch January 1, 2024 13:53
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants