Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder training preprocessing modules in extras tab #14367

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

w-e-w
Copy link
Collaborator

@w-e-w w-e-w commented Dec 19, 2023

fix issue #14360 Captions not being generated for flipped copies
since captioning is applied before flipping the image the flip the version of the image don't have captions

I reordered the five image training preprocessing modules using the order from before the rework 11d23e8 remove Train/Preprocessing tab and put all its functionality into extras batch images mode
(hopefully I didn't mess up the order)

current order new default
image image

personally I do not like 11d23e8 remove Train/Preprocessing tab and put all its functionality into extras batch images mode
I think the use case of preprocessing images for training and applying additional effects such as upscaling among other things that extensions do such as color enhancement are very different and should be separated
lots of people are not interested in training (or use other tools for training) would probably never uses preprocessing, for them this will be just cluttering the UI
the modules also cannot be disabled / hidden easily

personally I like the version before the rework, but I will have less of an issue if all these is grouped under a "big accordion"


there's also another issue caused by the rework

  • captioning is now extremely slow compared to what it was before
    irrc before captioning was done in a single large batch as opposed to being processed separately
    which means that you can just load and unload the model once reducing overhead

assuming that this is the only cause of the slowdown, then adding a function before_batch_processing and after_batch_processing can solve this issue, they can be used to load it unload the model

Checklist:

using the order from before the rework
11d23e8
@AUTOMATIC1111 AUTOMATIC1111 merged commit adcd65b into dev Dec 30, 2023
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the reorder-post-processing-modules branch December 30, 2023 12:23
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants