Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

torch_bgr_to_pil_image: round, don't truncate #14504

Merged
merged 1 commit into from
Jan 3, 2024

Conversation

akx
Copy link
Collaborator

@akx akx commented Jan 2, 2024

Description

This matches what realesrgan does.

I don't know if it will cause similar accuracy discrepancies with other upscalers though c.f. the old behavior(s).

Screenshots/videos:

I could post a black PNG here that shows the diff is now exactly zero (on my machine).

Checklist:

This matches what `realesrgan` does.
@akx akx requested a review from AUTOMATIC1111 as a code owner January 2, 2024 15:16
@AUTOMATIC1111 AUTOMATIC1111 merged commit 9c6ea53 into AUTOMATIC1111:dev Jan 3, 2024
3 checks passed
@w-e-w w-e-w mentioned this pull request Feb 17, 2024
@pawel665j pawel665j mentioned this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants