Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load extra networks html on create_ui #14990

Conversation

light-and-ray
Copy link
Contributor

@light-and-ray light-and-ray commented Feb 21, 2024

Description

After updating to 1.8 RC I've found two sad news for me.

  1. Reload button became invisible, and clickable only after loading html. So it's not possible to click on it if "Loading..." stocked. I think the problem in old Gradio, .load callbacks don't work in any cases. The bug is the same as in this PR: Button for refresh extensions list #14857 Also not only I have this bug, I saw it for few youtube guys
  2. Due to new folder system default extra networks page contains all models, and hides them only folder selected. And so the bug with endless loading converted from "randomly" to "stable" :) And I'm not able to load any extra networks on my laptop. (I use laptop to connect to my pc). The PC is significantly more powerful so the bug doesn't appear there

I tried to fix it, and found it's possible to load networks in create_ui time, with no "Loading..." placeholder. Al least I didn't find any errors in python and js consoles for default networks

Maybe you've added it because of webui loading time. So maybe I should add the option for this?

Screenshots/videos:

Screenshot_20240222_015816

Checklist:

@light-and-ray
Copy link
Contributor Author

light-and-ray commented Feb 21, 2024

Is there actual loading speed problem? Pasting html on starting server doesn't look like a performance issue, it should fast. Loading browser page also shouldn`t be changed, because these pages will be loaded in any way (Except this bug in my case...). Only the time between starting page loading and appearance of pseudo inactive ui can be increased, but this loading time is fake. And maybe even this problem doesn't exist

I think I need to make tests with timer. If there're not any also reasons why you made this 'loading...' placeholder

@AUTOMATIC1111
Copy link
Owner

Yes, it's because of load times. For people with a ton of loras, it can take multiple minutes to load them all, and if you do it in create_ui, it blocks the webui from starting. If the load callback fails somehow, this needs to be investigated. I was never able to reproduce that problem.

@light-and-ray
Copy link
Contributor Author

light-and-ray commented Feb 22, 2024

Temporary solution: 1da0529

I think need to be fixed only if a lot of people will have the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants