Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXIF orientation in API image loading #15062

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

burgalon
Copy link
Contributor

No description provided.

@burgalon burgalon force-pushed the fix-exif-orientation-api branch from 23984e7 to 122553c Compare February 29, 2024 09:25
@burgalon burgalon changed the base branch from master to dev February 29, 2024 09:25
@AUTOMATIC1111
Copy link
Owner

I feel that this belongs to images.py and should also be done for img2img image uploads...

@burgalon
Copy link
Contributor Author

burgalon commented Mar 3, 2024

@AUTOMATIC1111 do you mean i should just move the _apply_exif_orientation to images.py ? but still call it from within api.py?
Where is img2img loading an image that does not use decode_base64_to_image ?

@AUTOMATIC1111
Copy link
Owner

AUTOMATIC1111 commented Mar 3, 2024

Just put the function itself into images.py so that it can later be used not only for API but also for, say, img2img batch mode.

Also share an image for which those changes are needed.

@burgalon burgalon force-pushed the fix-exif-orientation-api branch from 122553c to 67d8daf Compare March 4, 2024 10:23
@burgalon
Copy link
Contributor Author

burgalon commented Mar 4, 2024

moved to images.py

@burgalon
Copy link
Contributor Author

burgalon commented Mar 4, 2024

burgalon added a commit to astriaai/stable-diffusion-webui-forge that referenced this pull request Mar 4, 2024
@AUTOMATIC1111 AUTOMATIC1111 merged commit 33fbe94 into AUTOMATIC1111:dev Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants