Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use diskcache library for caching #15287

Merged
merged 1 commit into from
Mar 17, 2024
Merged

use diskcache library for caching #15287

merged 1 commit into from
Mar 17, 2024

Conversation

AUTOMATIC1111
Copy link
Owner

Description

  • uses diskcache library for cache instead of a json file as it previously did
  • each subsection of cache (safetensors-metadata, hashes, extensions-git...) is its own diskcache.Cache object
  • uses SD_WEBUI_CACHE_DIR environment variable, defaults to cache directory
  • old json cache is automatically converted if it exists
  • the file for old cache is not removed for now, but is unused otherwise

Alternative to #12863. @w-e-w @akx @freecoderwaifu

@w-e-w
Copy link
Collaborator

w-e-w commented Mar 17, 2024

LGTM

@AUTOMATIC1111 AUTOMATIC1111 merged commit f1b090e into dev Mar 17, 2024
6 checks passed
@AUTOMATIC1111 AUTOMATIC1111 deleted the diskcache branch March 17, 2024 20:20
@AUTOMATIC1111 AUTOMATIC1111 mentioned this pull request Mar 17, 2024
Closed
4 tasks
@akx akx mentioned this pull request Mar 17, 2024
Merged
4 tasks
@brendanhoar brendanhoar mentioned this pull request Jun 11, 2024
Open
@w-e-w w-e-w mentioned this pull request Nov 3, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AUTOMATIC1111 @w-e-w @freecoderwaifu