Fix method 2 : patch__pkg_resources__packaging #15883
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
w-e-w
force-pushed
the
patch__pkg_resources__packaging
branch
from
7fbc5cd
to
2cc8955
Compare
ruchej
pushed a commit
to ruchej/stable-diffusion-webui
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
sd.webui.zip[Bug]: getting an import error about can't import name packaging from pkg_resources #15902the pkg_resources package was deprecated
https://github.com/pypa/setuptools/blob/5cbf12a9b63fd37985a4525617b46576b8ac3a7b/pkg_resources/__init__.py#L16-L17
and in
setuptools=70.0.0there was a change that breaks packeages that imports usespkg_resources.packaginga fix for now can be done by patching
pkg_resources.extern.packagingintopkg_resources.packagingthe real fix would be to update all dependencies to not use the deprecated pkg_resources
Checklist: