Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Prescription UI #152

Merged
merged 8 commits into from
Oct 27, 2021
Merged

Implement Prescription UI #152

merged 8 commits into from
Oct 27, 2021

Conversation

joshenx
Copy link

@joshenx joshenx commented Oct 27, 2021

Changes

  • Abstracted addPrescription method to Model. @huyuxin0429 take note.
  • Time and Date now shown separately on AppointmentCard
  • Methods implemented in Appointment class to retrieve Time and Date in UI-specific format
  • Known bug: adding a second prescription to the same Appointment is not reflected until the card is selected.

image

@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2021

Codecov Report

Merging #152 (9d0df36) into master (50efb68) will decrease coverage by 0.16%.
The diff coverage is 17.64%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #152      +/-   ##
============================================
- Coverage     53.39%   53.23%   -0.17%     
  Complexity      551      551              
============================================
  Files           116      116              
  Lines          2326     2337      +11     
  Branches        269      269              
============================================
+ Hits           1242     1244       +2     
- Misses          997     1006       +9     
  Partials         87       87              
Impacted Files Coverage Δ
.../commands/prescription/AddPrescriptionCommand.java 9.09% <0.00%> (-0.44%) ⬇️
...c/main/java/seedu/docit/model/AppointmentBook.java 55.55% <ø> (ø)
src/main/java/seedu/docit/model/Model.java 100.00% <ø> (ø)
...a/seedu/docit/model/prescription/Prescription.java 0.00% <0.00%> (ø)
src/main/java/seedu/docit/ui/AppointmentCard.java 0.00% <0.00%> (ø)
...ava/seedu/docit/model/appointment/Appointment.java 40.90% <40.00%> (-0.12%) ⬇️
.../java/seedu/docit/logic/commands/ClearCommand.java 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50efb68...9d0df36. Read the comment docs.

@joshenx joshenx linked an issue Oct 27, 2021 that may be closed by this pull request
Copy link

@huyuxin0429 huyuxin0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, very well done Joshen. I'll be giving you equal share + 200% for this commit alone. LGTM!!!!

src/main/java/seedu/docit/model/AppointmentBook.java Outdated Show resolved Hide resolved
@joshenx joshenx merged commit 79dc783 into master Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement GUI display for Prescription under Appointment Panel
3 participants