Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement test cases for MedicalHistory suite of classes #269

Merged
merged 14 commits into from
Nov 6, 2021

Conversation

didymental
Copy link

@didymental didymental commented Nov 5, 2021

EDIT: This PR is complete.

This PR resolves #266

@didymental didymental added this to the v1.4 milestone Nov 5, 2021
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2021

Codecov Report

Merging #269 (8886e14) into master (dfe7068) will increase coverage by 3.62%.
The diff coverage is 73.07%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #269      +/-   ##
============================================
+ Coverage     54.06%   57.68%   +3.62%     
- Complexity      572      607      +35     
============================================
  Files           118      118              
  Lines          2401     2408       +7     
  Branches        262      267       +5     
============================================
+ Hits           1298     1389      +91     
+ Misses         1021      933      -88     
- Partials         82       86       +4     
Impacted Files Coverage Δ
...u/docit/logic/commands/AddMedicalEntryCommand.java 85.71% <0.00%> (+85.71%) ⬆️
...a/seedu/docit/storage/JsonAdaptedMedicalEntry.java 75.00% <ø> (+25.00%) ⬆️
...ocit/logic/commands/DeleteMedicalEntryCommand.java 88.00% <50.00%> (+88.00%) ⬆️
.../logic/parser/DeleteMedicalEntryCommandParser.java 92.85% <66.66%> (+92.85%) ⬆️
...java/seedu/docit/model/patient/MedicalHistory.java 74.50% <100.00%> (+11.74%) ⬆️
...c/main/java/seedu/docit/model/patient/Patient.java 91.66% <100.00%> (+14.58%) ⬆️
...in/java/seedu/docit/model/util/SampleDataUtil.java 29.16% <100.00%> (-12.22%) ⬇️
...a/seedu/docit/model/patient/UniquePatientList.java 88.88% <0.00%> (+2.22%) ⬆️
...main/java/seedu/docit/logic/parser/ParserUtil.java 71.83% <0.00%> (+2.81%) ⬆️
src/main/java/seedu/docit/model/Entry.java 82.60% <0.00%> (+4.34%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfe7068...8886e14. Read the comment docs.

Copy link

@huyuxin0429 huyuxin0429 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty comprehensive tests of medical history class as well as its associated parser and commands. Good job!

@didymental didymental merged commit 7633504 into master Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Test Cases for Medical History in Patient class
3 participants