Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify invalid price output #183

Merged

Conversation

Banana3021
Copy link
Collaborator

No description provided.

@Banana3021 Banana3021 added priority.Medium Nice to have type.Bug A bug labels Nov 3, 2021
@Banana3021 Banana3021 added this to the v1.4 milestone Nov 3, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #183 (6276b68) into master (ee0d6ef) will decrease coverage by 5.68%.
The diff coverage is 5.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #183      +/-   ##
============================================
- Coverage     51.28%   45.60%   -5.69%     
- Complexity      467      470       +3     
============================================
  Files           106      115       +9     
  Lines          2135     2423     +288     
  Branches        245      273      +28     
============================================
+ Hits           1095     1105      +10     
- Misses          977     1252     +275     
- Partials         63       66       +3     
Impacted Files Coverage Δ
...in/java/seedu/address/commons/util/StringUtil.java 80.00% <0.00%> (-16.00%) ⬇️
...rc/main/java/seedu/address/logic/LogicManager.java 62.96% <0.00%> (-7.88%) ⬇️
...edu/address/logic/commands/AddShortcutCommand.java 0.00% <0.00%> (ø)
...seedu/address/logic/commands/CountdownCommand.java 0.00% <0.00%> (ø)
...java/seedu/address/logic/commands/FindCommand.java 100.00% <ø> (ø)
...ava/seedu/address/logic/commands/GroupCommand.java 0.00% <0.00%> (ø)
...du/address/logic/commands/ListShortcutCommand.java 0.00% <0.00%> (ø)
...ava/seedu/address/logic/commands/PriceCommand.java 0.00% <0.00%> (ø)
.../address/logic/commands/RemoveShortcutCommand.java 0.00% <0.00%> (ø)
...va/seedu/address/logic/commands/ReportCommand.java 0.00% <0.00%> (ø)
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee0d6ef...6276b68. Read the comment docs.

Copy link
Collaborator

@yin72257 yin72257 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Linda124 Linda124 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Banana3021 Banana3021 merged commit eac3e00 into AY2122S1-CS2103T-W10-4:master Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.Medium Nice to have type.Bug A bug
Projects
None yet
4 participants