Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI update v1.3 #67

Merged
merged 19 commits into from
Mar 23, 2023
Merged

Conversation

ajjajjajjajj
Copy link

Add working UI for Transactions

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #67 (8e5a85f) into master (2c0a3c4) will decrease coverage by 0.36%.
The diff coverage is 2.85%.

@@             Coverage Diff              @@
##             master      #67      +/-   ##
============================================
- Coverage     75.06%   74.70%   -0.36%     
- Complexity      617      649      +32     
============================================
  Files           102      106       +4     
  Lines          1965     2040      +75     
  Branches        238      245       +7     
============================================
+ Hits           1475     1524      +49     
- Misses          382      416      +34     
+ Partials        108      100       -8     
Impacted Files Coverage Δ
...ess/logic/commands/txncommands/EditTxnCommand.java 73.77% <ø> (ø)
.../seedu/address/logic/parser/AddressBookParser.java 79.16% <ø> (-3.45%) ⬇️
.../parser/txncommandparser/EditTxnCommandParser.java 61.90% <ø> (ø)
...a/seedu/address/model/transaction/Description.java 80.00% <ø> (ø)
src/main/java/seedu/address/ui/MainWindow.java 0.00% <0.00%> (ø)
src/main/java/seedu/address/ui/PersonCard.java 0.00% <0.00%> (ø)
...rc/main/java/seedu/address/ui/TransactionCard.java 0.00% <0.00%> (ø)
...in/java/seedu/address/ui/TransactionListPanel.java 0.00% <0.00%> (ø)
...c/main/java/seedu/address/model/person/Gender.java 72.72% <100.00%> (+2.72%) ⬆️

... and 8 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@WesleyBLDC
Copy link

LGTM but noted CI fails due to UI missing unit test.

@WesleyBLDC WesleyBLDC merged commit 320ae95 into AY2223S2-CS2103-W16-4:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants