Skip to content

Commit

Permalink
Merge pull request #229 from SeanChinJunKai/Branch-PPP
Browse files Browse the repository at this point in the history
Update PPP
  • Loading branch information
Creationsv2 authored Apr 9, 2023
2 parents bd66a76 + d4c0409 commit 900e4cf
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 8 deletions.
6 changes: 5 additions & 1 deletion docs/AboutUs.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ We are a team based in the [School of Computing, National University of Singapor
<img src="images/creationsv2.png" width="200px">

[[github](https://github.com/Creationsv2)]
[[portfolio](team/creationsv2.md)]

* Role: Developer
* Responsibilities: Data Querying
Expand All @@ -21,6 +22,7 @@ We are a team based in the [School of Computing, National University of Singapor
<img src="images/ongweijie7.png" width="200px">

[[github](http://github.com/ongweijie7)]
[[portfolio](team/ongweijie7.md)]

* Role: Developer
* Responsibilities: Data Filtering
Expand All @@ -30,6 +32,7 @@ We are a team based in the [School of Computing, National University of Singapor
<img src="images/seanchinjunkai.png" width="200px">

[[github](http://github.com/seanchinjunkai)]
[[portfolio](team/seanchinjunkai.md)]

* Role: Developer
* Responsibilities: Help function
Expand All @@ -39,7 +42,7 @@ We are a team based in the [School of Computing, National University of Singapor
<img src="images/dawg420.png" width="200px">

[[github](http://github.com/dawg420)]

[[portfolio](team/dawg420.md)]
* Role: Developer
* Responsibilities: Data Management/Storage

Expand All @@ -48,6 +51,7 @@ We are a team based in the [School of Computing, National University of Singapor
<img src="images/cedricpei.png" width="200px">

[[github](http://github.com/cedricpei)]
[[portfolio](team/cedricpei.md)]

* Role: Developer
* Responsibilities: GUI + Undo/redo + View
14 changes: 7 additions & 7 deletions docs/team/creationsv2.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Given below are my contributions to the project.

* **New Feature**: Added `nric` field in patient records. [#45](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/45)
* What it does: Allows users to store `nric` of patients and uniquely identify them my `nric`.
* Justification: This feature allows for easy unqiue identification of a patient.
* Justification: This feature allows for easy unqiue identification of a patient.
Previously uniqueness was checked by the `name` field, which is not ideal as two patients may have the same name.
* Highlights: To prevent incorrect formats, the `nric` field is only able to take in `nric`s with valid
formats.
Expand All @@ -25,32 +25,32 @@ Given below are my contributions to the project.
* Justification: This feature allows for easy filtering of patients by their conditions, represented by `tag`s.


* **New Feature**: Added `doctor` field in patient records.
* **New Feature**: Added `doctor` field in patient records.
[#121](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/121)
* What it does: Allows users to be tagged to an attending `doctor`.
* Justification: This feature allows for easy identification of patients by current attending `doctor`.
* Highlights: Attending `doctor` is now shown beside each patient for quick relational view.


* **New Feature**: Added ability to filter by attending `doctor` field.
* **New Feature**: Added ability to filter by attending `doctor` field.
[#123](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/123)
* What it does: Allows users to be filtered by their current attending `doctor`.
* Justification: This feature allows for easy filtering of patients by current attending `doctor`.


* **Code contributed**:
* **Code contributed**:
[RepoSense Link](https://nus-cs2103-ay2223s2.github.io/tp-dashboard/?search=Creationsv2&sort=groupTitle%20dsc&sortWithin=title&since=2023-02-17&timeframe=commit&mergegroup=&groupSelect=groupByRepos&breakdown=false)


* **Project Management**:
* **Project Management**:
* Organised and coordinated team meetings.
* Published Releases `v1.2b`, `v1.3.trial` and `v1.3.1`.
* Set up and maintained team Organisation and Repo.
* Used GitHub issue tracker.
* Reviewed and approved PRs for merging.


* **Enhancements to existing features**:
* **Enhancements to existing features**:
* Changed usage of `tag` classes to reflect patient conditions. [#86](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/86)
* Wrote test cases for `nric` classes. [#45](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/45), [#71](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/71)
* Wrote test cases for `doctor` classes. [#121](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/121)
Expand All @@ -73,7 +73,7 @@ Given below are my contributions to the project.

* **Documentation**:
* PRs reviewed (with non-trivial comments): [#42](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/42), [#76](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/76), [#125](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/125)
, [#131](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/131), [#134](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/134),
, [#131](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/131), [#134](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/134),
* Created a total of [27](https://github.com/AY2223S2-CS2103T-T11-4/tp/issues?q=is%3Aissue+author%3ACreationsv2+) issues for GitHub issue tracker.
* Reported a total of [12](https://github.com/Creationsv2/ped/issues) bugs and issues for PE-D.

11 changes: 11 additions & 0 deletions docs/team/seanchinjunkai.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,13 @@ Given below are my contributions to the project.
* **Project management** :
* Created tags for issue triaging.
* Reviewed and approved PRs for merging.
* PRs reviewed (with non-trivial comments): [\#71](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/71)
* Created a total of [5](https://github.com/AY2223S2-CS2103T-T11-4/tp/issues?q=is%3Aissue+author%3ASeanChinJunKai+) issues for GitHub issue tracker.


* **Enhancements to existing features**:
* Wrote test cases for `drugallergy` class [\#81](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/81), [\#96](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/96)
* Wrote test cases for `nric` class [\#96](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/96)


* **Documentation** :
Expand All @@ -41,3 +48,7 @@ Given below are my contributions to the project.
* Developer Guide
* Added implementation details for `delete` command with sequence diagrams [\#85](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/85), [\#88](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/88)
* Added table of contents and improve navigability [\#108](https://github.com/AY2223S2-CS2103T-T11-4/tp/pull/108)


* **Contributions beyond project team** :
* Reported a total of [6](https://github.com/SeanChinJunKai/ped/issues) bugs and issues for PE-D.

0 comments on commit 900e4cf

Please sign in to comment.