Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DeleteFieldCommand #137

Merged
merged 3 commits into from
Mar 30, 2023

Conversation

potty10
Copy link

@potty10 potty10 commented Mar 29, 2023

Update delete-field to delete fields too.

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.25 🎉

Comparison is base (b81945a) 77.77% compared to head (ad6d82b) 78.03%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #137      +/-   ##
============================================
+ Coverage     77.77%   78.03%   +0.25%     
- Complexity      579      582       +3     
============================================
  Files            79       79              
  Lines          1683     1689       +6     
  Branches        188      191       +3     
============================================
+ Hits           1309     1318       +9     
+ Misses          314      310       -4     
- Partials         60       61       +1     
Impacted Files Coverage Δ
.../internship/logic/commands/DeleteFieldCommand.java 86.36% <ø> (ø)
...ernship/logic/parser/DeleteFieldCommandParser.java 89.74% <33.33%> (+8.66%) ⬆️
...a/seedu/internship/logic/commands/CopyCommand.java 100.00% <100.00%> (ø)
.../internship/logic/commands/DeleteIndexCommand.java 85.18% <100.00%> (ø)
...a/seedu/internship/logic/commands/FindCommand.java 100.00% <100.00%> (ø)
...edu/internship/logic/parser/CopyCommandParser.java 77.77% <100.00%> (+6.34%) ⬆️
...ernship/logic/parser/DeleteIndexCommandParser.java 81.81% <100.00%> (+4.04%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@eugenetangkj
Copy link

Looks great to merge 👍

@eugenetangkj eugenetangkj merged commit eb36ffe into AY2223S2-CS2103T-T14-3:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants