fix edit sequence diagram

[seadragon2000341]

• cr returned
• updateselectedinternship

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (a32aed4) 79.55% compared to head (64d1d15) 79.55%.

Additional details and impacted files

@@            Coverage Diff            @@
##             master     #207   +/-   ##
=========================================
  Coverage     79.55%   79.55%           
+ Complexity      598      596    -2     
=========================================
  Files            80       80           
  Lines          1707     1707           
  Branches        192      188    -4     
=========================================
  Hits           1358     1358           
  Misses          292      292           
  Partials         57       57           

see 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[potty10]

Thanks for the edit. Should there be a method call here?

[seadragon2000341]

Thanks for the edit. Should there be a method call here?

Im not too sure about this actually. Because the method call is createEditedInternship(internshipToEdit, EditInternshipDescriptor) so it dosent actually go into EditInternshipDescriptor via the method call

[eugenetangkj]

@seadragon2000341

The createEditedInternship(internshipToEdit, EditInternshipDescriptor) is a static method of the class EditCommand, so I believe it should be making a call to the class EditCommand instead of an object of EditInternshipDescriptor.

Referring to the tutorial notes, it should look something like this:

Does it make more sense if we amend it as such?

[seadragon2000341]

@eugenetangkj @potty10

Ive changed to this image!

• edit command calls its own method (create edited internship)
• edit internshipdescriptor gets destroyed when edit command is destroyed (since editinternshipdescriptor is aprt of edit command)
  

[eugenetangkj]

Thanks for the effort! Looks great to merge 👍