Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create taskAddCommand Doc w/ Seq Diagram for DG #133

Merged

Conversation

bryanongjx
Copy link

create taskAddCommand Doc w/ Seq Diagram for DG

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.58 ⚠️

Comparison is base (ec14a22) 44.84% compared to head (ea9e18e) 43.26%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #133      +/-   ##
============================================
- Coverage     44.84%   43.26%   -1.58%     
- Complexity      591      592       +1     
============================================
  Files           151      155       +4     
  Lines          3055     3164     +109     
  Branches        332      350      +18     
============================================
- Hits           1370     1369       -1     
- Misses         1607     1714     +107     
- Partials         78       81       +3     

see 12 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* Pros: Easy to manage TaskList functionalities.
* Cons: May have performance issues due to numerous calls down command-specific parsers

* Alternative 2 : Use a simple
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you leave out the rest of the sentence?

participant ":Model" as Model MODEL_COLOR
end box

[-> LogicManager : execute("task add 1")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the significance of the '1'?

Copy link

@bokuanT bokuanT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but might have to look at PUML diagram comment

@bokuanT bokuanT merged commit 7b5665f into AY2223S2-CS2103T-T17-4:master Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants