Quality of Life refactors #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicleejy
approved these changes
Apr 4, 2023
There was a problem hiding this comment.
A good decision to let EditCommand be an interface which extends from Command, follows OOP principles more closely.
|
|
||
| if (!internalListOfCategories.remove(toRemove)) { | ||
| if (!internalListOfCategories.remove(category)) { | ||
| //Throw an exception here later |
There was a problem hiding this comment.
This part should be implemented by throwing an exception if the category to remove not being present in the list. If the Category was already checked to have been contained earlier, then this need not be an if statement.
| if (!recurringExpense.expenseCategory.equals(this.expenseCategory)) { | ||
| return false; | ||
| } | ||
|
|
||
| if (!recurringExpense.expenseName.equals(this.expenseName)) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
There could be a less repetitive way of doing this, can consider refactoring, but it is not a big issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.