Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix testing bugs, remove AddressBook from path #211

Merged
merged 6 commits into from
Apr 8, 2023

Conversation

shirsho-12
Copy link

closes #112

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Patch coverage: 43.60% and project coverage change: -24.04 ⚠️

Comparison is base (c670198) 71.52% compared to head (a92f812) 47.49%.

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #211       +/-   ##
=============================================
- Coverage     71.52%   47.49%   -24.04%     
- Complexity      428      491       +63     
=============================================
  Files            75      109       +34     
  Lines          1331     2472     +1141     
  Branches        138      262      +124     
=============================================
+ Hits            952     1174      +222     
- Misses          330     1193      +863     
- Partials         49      105       +56     
Impacted Files Coverage Δ
src/main/java/fasttrack/AppParameters.java 75.00% <ø> (ø)
src/main/java/fasttrack/Main.java 0.00% <ø> (ø)
src/main/java/fasttrack/MainApp.java 0.00% <0.00%> (ø)
src/main/java/fasttrack/commons/core/Config.java 68.18% <ø> (ø)
.../main/java/fasttrack/commons/core/GuiSettings.java 61.53% <ø> (ø)
...c/main/java/fasttrack/commons/core/LogsCenter.java 78.37% <ø> (ø)
src/main/java/fasttrack/commons/core/Messages.java 0.00% <0.00%> (ø)
src/main/java/fasttrack/commons/core/Version.java 82.50% <ø> (ø)
.../main/java/fasttrack/commons/core/index/Index.java 100.00% <ø> (ø)
...ck/commons/exceptions/DataConversionException.java 100.00% <ø> (ø)
... and 99 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link

@nicleejy nicleejy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the changes it looks like alot of our code is not covered by tests. LGTM overall

Copy link

@gitsac gitsac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on the refactoring and flagging out our lagging testcases, appears we might need to put in more work on the tests. LGTM.

@gitsac gitsac merged commit f6b4d91 into AY2223S2-CS2103T-W09-2:master Apr 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors in JUnit test cases
3 participants