-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix testing bugs, remove AddressBook from path #211
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #211 +/- ##
=============================================
- Coverage 71.52% 47.49% -24.04%
- Complexity 428 491 +63
=============================================
Files 75 109 +34
Lines 1331 2472 +1141
Branches 138 262 +124
=============================================
+ Hits 952 1174 +222
- Misses 330 1193 +863
- Partials 49 105 +56
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the changes it looks like alot of our code is not covered by tests. LGTM overall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on the refactoring and flagging out our lagging testcases, appears we might need to put in more work on the tests. LGTM.
closes #112