Bug fixes for UI, autocomplete #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #219 +/- ##
============================================
- Coverage 47.58% 47.46% -0.12%
Complexity 493 493
============================================
Files 109 109
Lines 2482 2488 +6
Branches 265 266 +1
============================================
Hits 1181 1181
- Misses 1195 1201 +6
Partials 106 106
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
shirsho-12
reviewed
Apr 9, 2023
Comment on lines
+118
to
+120
| if (event.getCode() == KeyCode.ENTER && suggestionsList.isVisible()) { | ||
| suggestionsList.setVisible(false); | ||
| } |
shirsho-12
reviewed
Apr 9, 2023
Comment on lines
+45
to
+48
| primaryStage.sizeToScene(); | ||
| primaryStage.setHeight(700); | ||
| primaryStage.setMinWidth(1000); | ||
| primaryStage.setMinHeight(700); |
There was a problem hiding this comment.
Ah the minimum and maximum size complaints
shirsho-12
approved these changes
Apr 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192
closes #185
closes #158