added test cases for other utility classes #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #225 +/- ##
============================================
+ Coverage 50.02% 50.46% +0.44%
- Complexity 526 531 +5
============================================
Files 109 109
Lines 2483 2483
Branches 266 266
============================================
+ Hits 1242 1253 +11
+ Misses 1126 1115 -11
Partials 115 115
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
shirsho-12
reviewed
Apr 10, 2023
Comment on lines
+70
to
+79
| @Test | ||
| public void parseCategoryWithSummary_validInput_success() throws ParseException { | ||
| // leading and trailing whitespace | ||
| assertEquals(new UserDefinedCategory("category", "abc"), ParserUtil.parseCategory(" category ", "abc")); | ||
| // miscellaneous category | ||
| assertEquals(new MiscellaneousCategory(), ParserUtil.parseCategory("miscellaneous")); | ||
| UserDefinedCategory category = ParserUtil.parseCategory("food", "for dining"); | ||
| assertEquals("food", category.getCategoryName()); | ||
| assertEquals("for dining", category.getSummary()); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #159