Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update DG #286

Merged
merged 6 commits into from
Apr 7, 2023
Merged

Update DG #286

merged 6 commits into from
Apr 7, 2023

Conversation

HmuuMyatMoe
Copy link

@HmuuMyatMoe HmuuMyatMoe commented Apr 7, 2023 •
edited
Loading

#128

  • Separated out Edit command activity diagram into 2 separate diagrams for better visibility
  • Add activity diagram and explanation for sort command
  • Edited User stories and DG
  • Minor cosmetic changes

@HmuuMyatMoe HmuuMyatMoe added this to the v1.4 milestone Apr 7, 2023
@HmuuMyatMoe HmuuMyatMoe requested a review from a team April 7, 2023 14:37
@codecov
Copy link

codecov bot commented Apr 7, 2023 •
edited
Loading

Codecov Report

Patch and project coverage have no change.

Comparison is base (2451b37) 60.20% compared to head (7f3409e) 60.20%.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master     #286   +/-   ##
=========================================
  Coverage     60.20%   60.20%           
  Complexity      851      851           
=========================================
  Files           172      172           
  Lines          3149     3149           
  Branches        396      396           
=========================================
  Hits           1896     1896           
  Misses         1173     1173           
  Partials         80       80

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@HmuuMyatMoe HmuuMyatMoe marked this pull request as ready for review April 7, 2023 14:44
LiuMC-SG
LiuMC-SG approved these changes Apr 7, 2023
View reviewed changes
Copy link

@LiuMC-SG LiuMC-SG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LiuMC-SG LiuMC-SG merged commit 93f9ad7 into AY2223S2-CS2103T-W15-2:master Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LiuMC-SG LiuMC-SG LiuMC-SG approved these changes

Assignees
No one assigned
Labels
None yet
Projects
tP
Status: Done
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@HmuuMyatMoe @LiuMC-SG