Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in vendor add command parser #109

Closed
tllshan opened this issue Oct 18, 2023 · 0 comments · Fixed by #116
Closed

Fix bug in vendor add command parser #109

tllshan opened this issue Oct 18, 2023 · 0 comments · Fixed by #116
Assignees
@p-xp
Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug

Comments

@tllshan
Copy link

tllshan commented Oct 18, 2023 •
edited by samuelim01
Loading

The vendor add command parser only accepts name and phone arguments. It is supposed to accept the following parameters:

  • name
  • phone
  • email
  • address
  • tag

Update VendorAddCommandParser to accept the remaining arguments, along with corresponding testcases.
@tllshan tllshan added type.Bug severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. labels Oct 18, 2023
@samuelim01 samuelim01 mentioned this issue Oct 19, 2023
Merged
@p-xp p-xp mentioned this issue Oct 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p-xp p-xp

Labels
severity.Medium A flaw that causes occasional inconvenience to some users but they can continue to use the product. type.Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix vendor add bug p-xp/tp
2 participants
@p-xp @tllshan