Create new UI and integrate all v1.2 changes #114
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #114 +/- ##
============================================
- Coverage 81.21% 78.19% -3.02%
+ Complexity 651 649 -2
============================================
Files 99 101 +2
Lines 1900 1963 +63
Branches 210 214 +4
============================================
- Hits 1543 1535 -8
- Misses 318 386 +68
- Partials 39 42 +3
☔ View full report in Codecov by Sentry. |
|
bruh how tf am i supposed to test the UI portions to satisfy codecov the original repo doesn't have it covered either |
|
Could I clarify the difference between the RSVP status of 
|
My intention behind designing the pie chart is that you can see the proportion of users who are confirmed to be coming at a glance. So I grouped those with RSVP status as We see what the others think? |
I do think the current labels on the pie chart could be quite misleading. What do y'all think of having three sections to reflect yes, no and unknown? |
There was a problem hiding this comment.
Thanks for your hard work! LGTM with a few nits. Ideally, I think this commit should be merged after #109 is fixed.
| * @return {@code RsvpStatistics} | ||
| */ | ||
| public RsvpStatistics getRsvpStatistics() { | ||
| return new RsvpStatistics(guests.getNumGuestsRsvpYes(), guests.getNumGuestsRsvpNo(), |
There was a problem hiding this comment.
Perhaps it would be better to implement the logic of getting RSVP statistics within UniqueGuestList? would also eliminate the need for getters.
There was a problem hiding this comment.
Actually I think the current implementation is fine, having our AddressBook class handle the creation of a RsvpStatistics object makes sense to me as the AddressBook has an overview of everything being tracked, and can derive RSVP information from its UniqueGuestList.
Currently, the UI is the same as the original AddressBook. All changes done in iteration 1.2 have been individually tested, but have not been integrated with the UI. There are also redundant classes such as
AddCommandwhich is deprecated due to the creation of more specificGuestAddCommandandVendorAddCommandclasses.Let's:
Disclaimer: UI is not polished yet and looks abit fugly. I will improve it next PR.
Addresses #87.