Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement guest edit feature #127

Merged
merged 19 commits into from
Oct 27, 2023
Merged

Implement guest edit feature #127

merged 19 commits into from
Oct 27, 2023

Conversation

p-xp
Copy link

@p-xp p-xp commented Oct 21, 2023 •
edited
Loading

Resolves #117.

Users are unable to edit Guests that have been created.

This is limiting as users have to delete and recreate Guests if they want to update any fields.

Let's implement functionality that allows users to edit Guest data.

@keaganpzh keaganpzh marked this pull request as draft October 22, 2023 02:52
@tllshan tllshan linked an issue Oct 23, 2023 that may be closed by this pull request
As a new user, I want to update RSVP status of a guest #56
Closed
p-xp added 5 commits October 24, 2023 00:13
@p-xp
Merge branch 'master' into guest-edit
5d42ee4
@p-xp
update guest edit tests
063711e
@p-xp
Update UG
901b7a0
@p-xp
Resolve merge conflicts with vendor-edit
dfa2716
@p-xp
Implement guest edit function
06e7952 
Users are not able to edit fields for created guests.

This is frustrating as they must remove and re-add a guest in order
to reflect changes.

Let's,
* Add GuestEditCommand and GuestEditCommandParser
* Modify GuestCommandParser to accept the new command
* Add EditGuestDescriptorBuilder for implementing tests
* Create tests for all the aforementioned newly-created classes
@p-xp p-xp requested a review from wasjoe1 October 25, 2023 04:07
@p-xp p-xp changed the title (DO NOT MERGE) Implement guest edit feature Implement guest edit feature Oct 25, 2023
@codecov
Copy link

codecov bot commented Oct 25, 2023 •
edited
Loading

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (e857e2a) 81.49% compared to head (50f34c0) 82.29%.

Additional details and impacted files 
@@             Coverage Diff              @@
##             master     #127      +/-   ##
============================================
+ Coverage     81.49%   82.29%   +0.80%     
- Complexity      816      844      +28     
============================================
  Files           116      118       +2     
  Lines          2416     2610     +194     
  Branches        277      319      +42     
============================================
+ Hits           1969     2148     +179     
- Misses          396      398       +2     
- Partials         51       64      +13
Files Coverage Δ
src/main/java/wedlog/address/logic/Messages.java 91.30% <100.00%> (+0.19%) ⬆️
...wedlog/address/logic/commands/GuestAddCommand.java 100.00% <ø> (ø)
...edlog/address/logic/parser/GuestCommandParser.java 100.00% <100.00%> (ø)
...main/java/wedlog/address/model/person/Address.java 92.85% <ø> (ø)
...dlog/address/logic/commands/VendorEditCommand.java 94.17% <0.00%> (ø)
...n/java/wedlog/address/logic/parser/ParserUtil.java 96.92% <0.00%> (-1.54%) ⬇️
...g/address/logic/parser/GuestEditCommandParser.java 88.88% <88.88%> (ø)
...edlog/address/logic/commands/GuestEditCommand.java 93.87% <93.87%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

wasjoe1
wasjoe1 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@wasjoe1 wasjoe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wasjoe1
Copy link
Collaborator

wasjoe1 commented Oct 25, 2023

Let's un-draft this PR to merge!

samuelim01
samuelim01 requested changes Oct 25, 2023
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but a few nits that need to be fixed first!

src/test/java/wedlog/address/logic/parser/CommandParserTestUtil.java Outdated Show resolved Hide resolved
src/test/java/wedlog/address/logic/parser/GuestEditCommandParserTest.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/parser/GuestEditCommandParser.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
@tllshan tllshan marked this pull request as ready for review October 26, 2023 09:53
samuelim01
samuelim01 requested changes Oct 26, 2023
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small bug fix needed!

src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/parser/GuestEditCommandParser.java Outdated Show resolved Hide resolved
src/main/java/wedlog/address/logic/commands/GuestEditCommand.java Outdated Show resolved Hide resolved
src/test/java/wedlog/address/logic/commands/EditGuestDescriptorTest.java Outdated Show resolved Hide resolved
@samuelim01 samuelim01 self-requested a review October 27, 2023 03:07
samuelim01
samuelim01 approved these changes Oct 27, 2023
View reviewed changes
Copy link

@samuelim01 samuelim01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work!

@wasjoe1 wasjoe1 merged commit 46a0da9 into AY2324S1-CS2103T-F11-2:master Oct 27, 2023
5 checks passed
@p-xp p-xp self-assigned this Oct 31, 2023
@p-xp p-xp added type.Enhancement An enhancement to an existing story priority.High Must do labels Oct 31, 2023
@p-xp p-xp added this to the v1.3 milestone Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wasjoe1 wasjoe1 wasjoe1 approved these changes

@samuelim01 samuelim01 samuelim01 approved these changes

Assignees

@p-xp p-xp

Labels
priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

As a user, I want to edit fields for a guest As a new user, I want to update RSVP status of a guest
3 participants
@p-xp @wasjoe1 @samuelim01