Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change dietary requirements implementation #141

Merged
merged 13 commits into from
Oct 25, 2023

Conversation

keaganpzh
Copy link
Member

Currently, the implementation of dietary requirements is a single value string that can either be present, none, or null.

This does not allow tracking of a guest with multiple dietary requirements.

To allow for tracking of multiple dietary requirements, let's:

  • Remove the existing DietaryRequirements class and fields.
  • Change the representation of dietary requirements in Guest to be a set of individual DietaryRequirement objects, i.e. Set<DietaryRequirement>.
  • Update the UI to reflect this new representation.
  • Rewrite all associated classes and test cases accordingly.

Addresses #132.

@keaganpzh keaganpzh added type.Enhancement An enhancement to an existing story priority.High Must do labels Oct 24, 2023
@keaganpzh keaganpzh added this to the v1.3 milestone Oct 24, 2023
@keaganpzh keaganpzh requested a review from tllshan October 24, 2023 12:28
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (ae77806) 79.98% compared to head (6d8711d) 80.07%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #141      +/-   ##
============================================
+ Coverage     79.98%   80.07%   +0.08%     
- Complexity      708      718      +10     
============================================
  Files           104      106       +2     
  Lines          2183     2233      +50     
  Branches        249      251       +2     
============================================
+ Hits           1746     1788      +42     
- Misses          388      396       +8     
  Partials         49       49              
Files Coverage Δ
...c/main/java/wedlog/address/logic/LogicManager.java 73.07% <100.00%> (+1.07%) ⬆️
...og/address/logic/parser/GuestAddCommandParser.java 100.00% <100.00%> (ø)
...n/java/wedlog/address/logic/parser/ParserUtil.java 98.46% <100.00%> (+0.18%) ⬆️
...rc/main/java/wedlog/address/model/AddressBook.java 90.62% <100.00%> (+0.14%) ⬆️
...og/address/model/DietaryRequirementStatistics.java 100.00% <100.00%> (ø)
src/main/java/wedlog/address/model/Model.java 100.00% <ø> (ø)
...c/main/java/wedlog/address/model/ModelManager.java 100.00% <100.00%> (ø)
...c/main/java/wedlog/address/model/person/Guest.java 96.66% <100.00%> (ø)
...a/wedlog/address/model/person/UniqueGuestList.java 92.00% <100.00%> (+1.37%) ⬆️
...a/wedlog/address/model/tag/DietaryRequirement.java 100.00% <100.00%> (ø)
... and 5 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@keaganpzh keaganpzh marked this pull request as ready for review October 24, 2023 12:30
@keaganpzh keaganpzh marked this pull request as draft October 24, 2023 12:30
@keaganpzh keaganpzh linked an issue Oct 24, 2023 that may be closed by this pull request
@keaganpzh keaganpzh marked this pull request as ready for review October 24, 2023 13:56
Copy link

@tllshan tllshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! LGTM

@tllshan tllshan merged commit 80f7fda into AY2324S1-CS2103T-F11-2:master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority.High Must do type.Enhancement An enhancement to an existing story
Projects
None yet
2 participants