forked from nus-cs2103-AY2324S1/tp
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change dietary requirements implementation #141
Merged
tllshan
merged 13 commits into
AY2324S1-CS2103T-F11-2:master
from
keaganpzh:branch-update-DR
Oct 25, 2023
Merged
Change dietary requirements implementation #141
tllshan
merged 13 commits into
AY2324S1-CS2103T-F11-2:master
from
keaganpzh:branch-update-DR
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keaganpzh
added
type.Enhancement
An enhancement to an existing story
priority.High
Must do
labels
Oct 24, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
============================================
+ Coverage 79.98% 80.07% +0.08%
- Complexity 708 718 +10
============================================
Files 104 106 +2
Lines 2183 2233 +50
Branches 249 251 +2
============================================
+ Hits 1746 1788 +42
- Misses 388 396 +8
Partials 49 49
☔ View full report in Codecov by Sentry. |
tllshan
reviewed
Oct 24, 2023
tllshan
reviewed
Oct 25, 2023
src/test/java/wedlog/address/model/DietaryRequirementStatisticsTest.java
Outdated
Show resolved
Hide resolved
tllshan
approved these changes
Oct 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the implementation of dietary requirements is a single value string that can either be present, none, or null.
This does not allow tracking of a guest with multiple dietary requirements.
To allow for tracking of multiple dietary requirements, let's:
DietaryRequirements
class and fields.Guest
to be a set of individualDietaryRequirement
objects, i.e.Set<DietaryRequirement>
.Addresses #132.