Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DG: Add delete feature #146

Merged
merged 9 commits into from
Oct 27, 2023

Conversation

tllshan
Copy link

@tllshan tllshan commented Oct 26, 2023

  • Add implementation for delete in DG
  • Add sequence diagrams for the parsing and execution of a delete command
    image
    image

@tllshan tllshan added the documentation Improvements or additions to documentation label Oct 26, 2023
@tllshan tllshan requested a review from p-xp October 26, 2023 17:59
@tllshan tllshan added the priority.High Must do label Oct 26, 2023
@tllshan tllshan added this to the v1.3 milestone Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9d2de58) 82.29% compared to head (ae6d80a) 82.29%.

❗ Current head ae6d80a differs from pull request most recent head 768b6ba. Consider uploading reports for the commit 768b6ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #146   +/-   ##
=========================================
  Coverage     82.29%   82.29%           
  Complexity      844      844           
=========================================
  Files           118      118           
  Lines          2610     2610           
  Branches        319      319           
=========================================
  Hits           2148     2148           
  Misses          398      398           
  Partials         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tllshan tllshan marked this pull request as draft October 26, 2023 18:02
docs/DeveloperGuide.md Outdated Show resolved Hide resolved
@tllshan tllshan marked this pull request as ready for review October 27, 2023 01:13
@tllshan tllshan requested a review from p-xp October 27, 2023 01:21
Copy link

@p-xp p-xp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits!

docs/DeveloperGuide.md Show resolved Hide resolved
@tllshan tllshan marked this pull request as draft October 27, 2023 01:34
@tllshan tllshan marked this pull request as ready for review October 27, 2023 06:06
@p-xp p-xp self-requested a review October 27, 2023 06:10
@tllshan tllshan merged commit 296c28a into AY2324S1-CS2103T-F11-2:master Oct 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority.High Must do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants