-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DG: Add delete feature #146
DG: Add delete feature #146
Conversation
tllshan
commented
Oct 26, 2023
•
edited by p-xp
Loading
edited by p-xp
- Add implementation for delete in DG
- Add sequence diagrams for the parsing and execution of a delete command
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 82.29% 82.29%
Complexity 844 844
=========================================
Files 118 118
Lines 2610 2610
Branches 319 319
=========================================
Hits 2148 2148
Misses 398 398
Partials 64 64 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just a few nits!