Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging for JsonAdaptedPerson and EditCommand #198

Merged
merged 1 commit into from
Nov 12, 2023

Conversation

dickongwd
Copy link

No description provided.

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (f743195) 61.13% compared to head (786514e) 61.38%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     61.13%   61.38%   +0.24%     
- Complexity      572      573       +1     
============================================
  Files           100      100              
  Lines          2398     2416      +18     
  Branches        221      221              
============================================
+ Hits           1466     1483      +17     
- Misses          854      855       +1     
  Partials         78       78              
Files Coverage Δ
...java/seedu/address/logic/commands/EditCommand.java 94.26% <100.00%> (+0.19%) ⬆️
.../java/seedu/address/storage/JsonAdaptedPerson.java 92.30% <92.85%> (+0.08%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dickongwd dickongwd added this to the v1.4 milestone Nov 12, 2023
@dickongwd dickongwd merged commit 43a5cea into AY2324S1-CS2103T-F11-4:master Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant