Add remark feature #166
Merged
Add remark feature #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the logic part, implement remark feature by create RemarkCommmand class, RemarkCommand parser and make sure can parse the command correctly. For the model part add the remark into person, modify all other class that use the person constructor. After that is the UI part, integrate remark as a label into PersonCard, add the label into the PersonListCard.fxml. Lastly, implement the junit testcases to make sure everythin works correctly.
# Conflicts: # src/main/java/seedu/address/logic/commands/EditCommand.java # src/main/java/seedu/address/logic/parser/AddCommandParser.java # src/main/java/seedu/address/logic/parser/AddressBookParser.java # src/main/java/seedu/address/logic/parser/CliSyntax.java # src/main/java/seedu/address/model/person/Person.java # src/main/java/seedu/address/model/util/SampleDataUtil.java # src/main/java/seedu/address/storage/jsonadaptedperson/JsonAdaptedPerson.java # src/main/java/seedu/address/ui/PersonCard.java # src/main/resources/view/PersonListCard.fxml # src/test/java/seedu/address/logic/commands/CommandTestUtil.java # src/test/java/seedu/address/model/person/PersonTest.java # src/test/java/seedu/address/testutil/PersonBuilder.java
update components including storage, model, logic to pass all the current test cases.
|
Is it better to not show the remark card if there is not remark? |
yucongkoo
reviewed
Oct 26, 2023
There was a problem hiding this comment.
Would excluding this file from you commit be better, since it is not ready?
|
Do you plan to update the output display when adding a person with remarks? Currently when we use the add command, the output will not show information about the remarks. However, remarks tend to be lengthy and I am not very sure should we show it in the output. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is how the UI look like:
I limit the length of remark to 150 characters long, longer the 150 is invalid remark.
If there is no remark, UI will show "No remark"