Fix minor UML errors and remove placeholders

AY2324S2-CS2103T-W08-1 · Apr 14, 2024 · 108ac06 · 108ac06
1 parent fe14ae5
commit 108ac06
Show file tree

Hide file tree

Showing 7 changed files with 7 additions and 10 deletions.
diff --git a/docs/DeveloperGuide.md b/docs/DeveloperGuide.md
@@ -334,7 +334,7 @@ Step 3. `TagCommandParser#parse(String)` creates a new `TagCommand` object, whic
 
 Step 4.`TagCommand#execute(Model)` is then called in `LogicManager#execute(String)`, where the matching `Person` is found and the union of tags present and tags to add is calculated. A new person is created using the tag union and the old person's data. Then, the old person is updated in the person list with `ModelManager#setPerson(Person, Person)`, the filtered person list in the model is updated with `ModelManager#updateFilteredPersonList(Predicate<Person>)`, and the applications in the application list are updated to contain the edited person with `ModelManager#replaceApplications(Person, Person)`.
 
-The following sequence diagram shows how a add_app operation goes through the various components:
+The following sequence diagram shows how a tag operation goes through the various components:
 
 ![TagSequenceDiagram](images/TagSequenceDiagram.png)
 
@@ -420,11 +420,6 @@ The following activity diagram summarizes what happens when a user executes a ne
   * Pros: Will use less memory (e.g. for `delete`, just save the person being deleted).
   * Cons: We must ensure that the implementation of each individual command are correct.
 
-_{more aspects and alternatives to be added}_
-
-### \[Proposed\] Data archiving
-
-_{Explain here how the data archiving feature will be implemented}_
 
 
 --------------------------------------------------------------------------------------------------------------------

diff --git a/docs/diagrams/LogicClassDiagram.puml b/docs/diagrams/LogicClassDiagram.puml
@@ -14,6 +14,7 @@ Class "{abstract}\nCommand" as Command
 Class "{abstract}\nConfirmableCommand" as ConfirmableCommand
 Class "{abstract}\nAbstractDeleteCommand" as ADCommand
 Class XYZDeleteCommand
+Enum "<<enumeration>>\nCommandBoxState" as CommandBoxState
 
 Class "<<interface>>\nLogic" as Logic
 Class LogicManager
@@ -30,7 +31,7 @@ Class HiddenOutside #FFFFFF
 HiddenOutside ..> Logic
 
 LogicManager .right.|> Logic
-LogicManager -left->"1" ParserClasses
+LogicManager -left->"2" ParserClasses
 ParserClasses ..> XYZCommand : <<create>>
 ParserClasses ..>XYZDeleteCommand : <<create>>
 
@@ -39,6 +40,8 @@ LogicManager .left.> Command : <<call>>
 
 LogicManager --> Model
 LogicManager --> Storage
+CommandBoxState -right[hidden]->CommandResult
+LogicManager -> CommandBoxState
 Storage --[hidden] Model
 Command .[hidden]up.> Storage
 Command .right.> Model

diff --git a/docs/diagrams/ParserClasses.puml b/docs/diagrams/ParserClasses.puml
@@ -24,8 +24,8 @@ HiddenOutside ..> ConfirmationStageParser
 HiddenOutside ..> AddressBookParser
 AddressBookParser .down.> XYZCommandParser: <<create>>
 
-ConfirmationStageParser ..> Command: <<confirm>>
-ConfirmationStageParser ..> Command: <<deny>>
+ConfirmationStageParser --> Command: <<confirm>>
+ConfirmationStageParser --> Command: <<deny>>
 XYZCommandParser ..> XYZCommand : <<create>>
 AddressBookParser ..> Command : <<use>>
 XYZCommandParser .up.|> Parser

diff --git a/docs/diagrams/SearchSequenceDiagram.puml b/docs/diagrams/SearchSequenceDiagram.puml
@@ -42,7 +42,6 @@ deactivate SearchPersonDescriptor
 
 create SearchCommand
 SearchCommandParser -> SearchCommand
-activate SearchCommandCommand
 
 
 SearchCommand --> SearchCommandParser

diff --git a/docs/images/LogicClassDiagram.png b/docs/images/LogicClassDiagram.png
diff --git a/docs/images/ParserClasses.png b/docs/images/ParserClasses.png
diff --git a/docs/images/SearchSequenceDiagram.png b/docs/images/SearchSequenceDiagram.png