-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Comment command for users to leave comments #1
Implement Comment command for users to leave comments #1
Conversation
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few nits, LGTM. Well done!
src/main/java/seedu/address/logic/parser/CommentCommandParser.java
Outdated
Show resolved
Hide resolved
src/test/java/seedu/address/logic/commands/CommentCommandTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
10e689d
into
AY2324S2-CS2103T-W08-1:master
The following files were modified or created:
new file: src/main/java/seedu/address/logic/commands/CommentCommand.java
modified: src/main/java/seedu/address/logic/commands/EditCommand.java
modified: src/main/java/seedu/address/logic/parser/AddCommandParser.java
modified: src/main/java/seedu/address/logic/parser/AddressBookParser.java
modified: src/main/java/seedu/address/logic/parser/CliSyntax.java
new file: src/main/java/seedu/address/logic/parser/CommentCommandParser.java
new file: src/main/java/seedu/address/model/person/Comment.java
modified: src/main/java/seedu/address/model/person/Person.java
modified: src/main/java/seedu/address/storage/JsonAdaptedPerson.java
modified: src/main/java/seedu/address/ui/PersonCard.java
modified: src/main/resources/view/PersonListCard.fxml
modified: src/test/data/JsonSerializableAddressBookTest/duplicatePersonAddressBook.json
modified: src/test/data/JsonSerializableAddressBookTest/typicalPersonsAddressBook.json
modified: src/test/java/seedu/address/logic/commands/CommandTestUtil.java
new file: src/test/java/seedu/address/logic/commands/CommentCommandTest.java
modified: src/test/java/seedu/address/storage/JsonAdaptedPersonTest.java
modified: src/test/java/seedu/address/testutil/PersonBuilder.java
modified: src/test/java/seedu/address/testutil/TypicalPersons.java