Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get_assets_url() won't return the api url containing jq binary assets, only on macOS #1

Closed
AZMCode opened this issue Dec 4, 2020 · 2 comments

Comments

@AZMCode
Copy link
Owner

AZMCode commented Dec 4, 2020

I've tried debugging this as much as I could, but I simply don't have access to a macOS system to debug effectively.

@AZMCode AZMCode self-assigned this Dec 4, 2020
@AZMCode
Copy link
Owner Author

AZMCode commented Dec 4, 2020

Oh lord it might be sed

@AZMCode
Copy link
Owner Author

AZMCode commented Dec 4, 2020

It was sed. Thankfully POSIX-compliant regexes saveed the day. Bug is fixed.

@AZMCode AZMCode closed this as completed Dec 4, 2020
@AZMCode AZMCode removed their assignment Dec 4, 2020
AZMCode added a commit that referenced this issue Dec 4, 2020
The plugin can now select between various files available in a release in a smarter way.
Fixes #1
iGEL pushed a commit to pitch-io/asdf-jq that referenced this issue Feb 1, 2024
…ZMCode#1)

It looks like the library organization in GitHub has changed, which breaks most of the operations in the plugin.

Test Plan:

- [x] `asdf list all jq` actually returns a list of versions after the change.
- [x] `asdf install jq 1.6` runs without error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant