Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge grid converter system models, controls and utilities adapted from gritulator #136

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Merge grid converter system models, controls and utilities adapted from gritulator #136

merged 9 commits into from
Aug 19, 2024

Conversation

maattaj11
Copy link
Contributor

@maattaj11 maattaj11 commented Aug 13, 2024 •
edited
Loading

This pull request contains grid converter-related system models, controls and utilities which have been migrated from gritulator. The main features are:

  • Subsystem models for converter output filters and 3-phase voltage sources.
  • Interconnector model for a grid converter system with converter, filter and grid.
  • Grid converter control system along with grid-following and grid-forming control methods
  • Dataclasses for filter and grid parameters.
  • Plotting functions
  • Example scripts showcasing the usage of these features

maattaj11 and others added 5 commits August 13, 2024 10:19
@maattaj11 @MiSaren
Added grid-related system models.
66ed79f 
Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
Small additions to Model class, added dynamic DC bus model to Inverte…
6892ee1 
…r class, added DiodeBridge subsystem, added ACFilter parent class. FrequencyConverter class can be replaced by Inverter, DiodeBridge and voltage source from grid.model

Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
Added grid-related utilities: plotting functions and GridPars dataclass
d4f77bb 
Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
Additions/changes to common utilities: moved NominalValues and BaseVa…
0f19a44 
…lues data classes, added FilterPars dataclass.

Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11
common.model fixes: re-added old inverter class for compatibility wit…
a85bfc8 
…h FrequencyConverter, fixed import in _ac_filter, moved meas-methods from ACFilter class to correct subclasses
@maattaj11 maattaj11 marked this pull request as ready for review August 13, 2024 11:46
@mhinkkan mhinkkan requested a review from rayanmour August 14, 2024 05:54
rayanmour
rayanmour reviewed Aug 15, 2024
View reviewed changes
Copy link

@rayanmour rayanmour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions and comments for further improvement which can be implemented in this PR or in a future one. The next PR could include one or two simple examples to illustrate how the different modules work.

motulator/common/utils/_utils.py Outdated Show resolved Hide resolved
motulator/common/utils/_utils.py Show resolved Hide resolved
motulator/common/model/_ac_filter.py Outdated Show resolved Hide resolved
motulator/common/model/_simulation.py Outdated Show resolved Hide resolved
motulator/grid/model/_grid_filter.py Outdated Show resolved Hide resolved
motulator/grid/utils/_plots.py Outdated Show resolved Hide resolved
motulator/grid/utils/_plots.py Outdated Show resolved Hide resolved
motulator/grid/utils/_plots.py Outdated Show resolved Hide resolved
motulator/grid/utils/_plots.py Outdated Show resolved Hide resolved
motulator/grid/utils/_plots.py Outdated Show resolved Hide resolved
@mhinkkan mhinkkan marked this pull request as draft August 15, 2024 11:56
mhinkkan
mhinkkan requested changes Aug 15, 2024
View reviewed changes
Copy link
Member

@mhinkkan mhinkkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work! We have added some comments to the code that could be addressed before merging these changes.

motulator/common/model/_converter.py Outdated Show resolved Hide resolved
motulator/common/utils/_utils.py Outdated Show resolved Hide resolved
motulator/grid/model/_grid_converter_system.py Show resolved Hide resolved
maattaj11 and others added 4 commits August 16, 2024 13:59
@maattaj11 @MiSaren
Implemented changes in model/utils according to code review
bfd317f 
Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
-Implemented changes to drive modules to facilitate usage of DiodeBri…
e24fb1b 
…dge class: added new system model, edits to plotting function. -Small fixes in LCFilter.

Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
-Added control classes for grid converters: generic control system cl…
976a46f 
…ass, grid-following and grid-forming control methods. -Added feedforward for complexPIcontroller.

Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 @MiSaren
Added example scripts for grid-following and grid-forming control, ed…
338ba1f 
…ited some drive examples to work with updated models, other small fixes.

Co-authored-by: Mikko Sarén <mikko.saren@aalto.fi>
@maattaj11 maattaj11 marked this pull request as ready for review August 16, 2024 13:33
@maattaj11 maattaj11 changed the title Merge system models and utilities from gritulator Merge grid converter system models, controls and utilities adapted from gritulator Aug 16, 2024
mhinkkan
mhinkkan approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@mhinkkan mhinkkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good! I have some comments about details in mind, but let us take them into account separately.

motulator/common/utils/_utils.py Outdated Show resolved Hide resolved
@mhinkkan mhinkkan merged commit 75aef83 into Aalto-Electric-Drives:main Aug 19, 2024
1 check failed
@mhinkkan
Copy link
Member

Thanks for planning and rewriting the gritulator code for motulator, well done!

@all-contributors please add @maattaj11 for code and examples and ideas
@all-contributors please add @MiSaren for code and examples and ideas

Thanks also for the original authors of gritulator!

@all-contributors please add @rayanmour for code and examples and ideas and review
@all-contributors please add @jarno-k for ideas and review

This was referenced Aug 19, 2024
Closed
Merged
Merged
@maattaj11 maattaj11 deleted the aalto-main branch August 19, 2024 07:24
@allcontributors allcontributors bot mentioned this pull request Aug 19, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@mhinkkan

I've put up a pull request to add @thanks! 🎉

I've put up a pull request to add @maattaj11! 🎉

I've put up a pull request to add @MiSaren! 🎉

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @rayanmour! 🎉

We had trouble processing your request. Please try again later.

@mhinkkan
Copy link
Member

@all-contributors please add @jarno-k for mentoring and review

@allcontributors AllContributors
Copy link
Contributor

@mhinkkan

@jarno-k already contributed before to mentoring, review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiSaren MiSaren MiSaren left review comments

@mhinkkan mhinkkan mhinkkan approved these changes

@rayanmour rayanmour Awaiting requested review from rayanmour

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maattaj11 @mhinkkan @rayanmour @MiSaren