Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unsupported chars from filenames #63

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

tomwwinter
Copy link
Contributor

No description provided.

@tomwwinter tomwwinter requested a review from sadaf895 January 21, 2025 10:57
@tomwwinter tomwwinter force-pushed the tw/refactor/filename-support-for-windows branch from 25b48ff to d7f305e Compare January 21, 2025 11:13
Copy link

Code Coverage Analyse

Overall Project 59.7%

There is no coverage information present for the Files changed

@tomwwinter tomwwinter force-pushed the tw/refactor/filename-support-for-windows branch from d7f305e to ba35bdd Compare January 21, 2025 11:26
@tomwwinter tomwwinter requested a review from sleidig January 21, 2025 12:07
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and tests still run and mostly pass on my local machine as well.

The following tests fail both in main and this branch for me, however (so maybe unrelated ...):
Screenshot From 2025-01-21 14-44-51

@tomwwinter tomwwinter merged commit 9d1e896 into main Jan 22, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants