Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export only displayed data #1361

Closed
TheSlimvReal opened this issue Jul 12, 2022 · 5 comments · Fixed by #2059
Closed

Export only displayed data #1361

TheSlimvReal opened this issue Jul 12, 2022 · 5 comments · Fixed by #2059
Assignees
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature

Comments

@TheSlimvReal
Copy link
Collaborator

TheSlimvReal commented Jul 12, 2022

Users who regularly use the export feature (accessed through the three-dot menu at the top right of list views) sometimes complain, that it exports all the data instead of just the one that they have filtered for in the list view.

E.g. if somebody filtered the children for a certain center, when exporting the children, only the children from this center should be exported. Same goes with other selectable or text filters. In the end only the data that is shown in the table should be exported.

TO DISCUSS should this replace the current behavior of exporting all children, should there be one button for each or we add a popup warning the user when only filtered data is exported?

Proposed Solutions & Alternatives
This can probably be achieved easily by using entitySubrecord.recordsDataSource.data for the appExportData directive in the EntityListComponent

@TheSlimvReal TheSlimvReal added the Type: Feature new user-facing feature label Jul 12, 2022
@sleidig sleidig moved this to Triage in All Tasks & Issues Jul 18, 2022
@sleidig sleidig moved this from Triage to Todo in All Tasks & Issues Jul 18, 2022
@sleidig
Copy link
Member

sleidig commented Oct 12, 2022

This point has come up again while answering questions of actual users. I do think the more intuitive (and useful/powerful) behavior is to export only the filter, visible data. (Of course including all pages of the pagination).

@TheSlimvReal
Copy link
Collaborator Author

Maybe also only export the columns that are currently shown.

@sleidig sleidig added the CC label Sep 20, 2023
@brajesh-lab brajesh-lab moved this from Todo [help wanted] to In Progress in All Tasks & Issues Nov 2, 2023
@brajesh-lab brajesh-lab self-assigned this Nov 2, 2023
brajesh-lab pushed a commit that referenced this issue Nov 2, 2023
sleidig added a commit that referenced this issue Nov 6, 2023
closes #1361

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@github-project-automation github-project-automation bot moved this from In Progress to Done in All Tasks & Issues Nov 6, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.26.0-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 6, 2023
sleidig added a commit that referenced this issue Nov 6, 2023
closes #1361

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
sleidig added a commit that referenced this issue Nov 6, 2023
closes #1361

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.26.0-master.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

sleidig added a commit that referenced this issue Nov 7, 2023
closes #1361

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
sleidig added a commit that referenced this issue Nov 8, 2023
closes #1361

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release) Type: Feature new user-facing feature
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants