Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Matching Component to also handle multi-select / entity-array cases #1984

Merged
merged 4 commits into from
Aug 24, 2023
Merged

Enable Matching Component to also handle multi-select / entity-array cases #1984

merged 4 commits into from
Aug 24, 2023

Conversation

sleidig
Copy link
Member

@sleidig sleidig commented Aug 23, 2023 •
edited
Loading

Extends the MatchingEntitiesComponent to support "group matchings":

  • whether group / multiSelect is possible is inferred from the entity schema of the property defined in the onMatch config for the matching to be created
  • multiSelect mode allows to highlight multiple rows in the selection table and create a match filling the entity-array datatype property
  • single select continues to work as previously

To test:

  • run locally and switch ChildSchoolRelation.childId datatype from "entity" to "entity-array" (leave the typescript type as string - our fallbacks can handle that)
  • to see the group matchings in the Education History list correctly, the ChildSchoolOverview also needs to be replace by RelatedTimePeriodEntities component

@github-actions
Copy link

Deployed to https://pr-1984.aam-digital.net/

TheSlimvReal
TheSlimvReal approved these changes Aug 24, 2023
View reviewed changes
Copy link
Collaborator

@TheSlimvReal TheSlimvReal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very seamlessly. Good job.

src/app/features/matching-entities/matching-entities/matching-entities.component.ts Outdated Show resolved Hide resolved
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sleidig sleidig merged commit 669e912 into master Aug 24, 2023
@sleidig sleidig deleted the matching-multi branch August 24, 2023 09:09
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.24.0-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheSlimvReal TheSlimvReal TheSlimvReal approved these changes

Assignees
No one assigned
Labels
released managed by CI (semantic-release)
Projects
All Tasks & Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sleidig @aam-digital-ci @TheSlimvReal