Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display dynamic value #1992

Merged
merged 25 commits into from
Sep 21, 2023
Merged

Display dynamic value #1992

merged 25 commits into from
Sep 21, 2023

Conversation

christophscheuing
Copy link
Contributor

closes: #1806

Visible/Frontend Changes

  • added new component to show a dynamically calculated percentage from two values of the given entity

@github-actions
Copy link

github-actions bot commented Sep 7, 2023

Deployed to https://pr-1992.aam-digital.net/

@christophscheuing christophscheuing marked this pull request as ready for review September 7, 2023 17:19
TheSlimvReal and others added 3 commits September 8, 2023 14:21
@TheSlimvReal @sleidig
feat(core): configurable styles for whole platform (#1953)
5bc0b08 
this enables user-configured "white-label" design of the system in custom colors

MIGRATION NECESSARY: see PR #1953

closes #1949
---------

Co-authored-by: Sebastian <sebastian@aam-digital.com>
@sleidig
Merge branch 'master' into display_dynamic_value
22bd1d8
@sleidig
rename
e4e5dda
sleidig
sleidig reviewed Sep 8, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks @christophscheuing !

I noticed this is not updating its value when you edit the related values (e.g. the "total" property of the entity), however. Seems a bit messy with our system, onChanges is not firing for this ...
I'll look into it further.

...ild-dev-project/children/health-checkup/health-checkup-component/health-checkup.component.ts Outdated Show resolved Hide resolved
src/app/core/basic-datatypes/entity/display-entity/display-entity.stories.ts Outdated Show resolved Hide resolved
sleidig and others added 2 commits September 8, 2023 14:46
@sleidig
Update src/app/core/basic-datatypes/entity/display-entity/display-ent…
7dfa6f7 
…ity.stories.ts
@christophscheuing @sleidig
Removal of this test
530a955 
Co-authored-by: Sebastian <sebastian@aam-digital.com>
@TheSlimvReal
Merge branch 'master' into display_dynamic_value
7701d09 
# Conflicts:
#	package-lock.json
#	src/app/core/site-settings/site-settings.service.ts
#	src/styles/variables/_colors.scss
@sleidig sleidig mentioned this pull request Sep 18, 2023
Open
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TheSlimvReal
Copy link
Collaborator

The only way I was able to solve the issue with the change detection was by always re-calculating the result.

@sleidig sleidig merged commit 4bf13b3 into master Sep 21, 2023
6 checks passed
@sleidig sleidig deleted the display_dynamic_value branch September 21, 2023 15:28
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.24.0-master.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Sep 21, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column (DisplayComponent) "calculated percentage"
4 participants
@christophscheuing @TheSlimvReal @aam-digital-ci @sleidig