fix(*): correctly allow date ranges where start date is in future

[sleidig]

allow date ranges where start date is in future and no end date is set

⚠️ mark commit for @codo-mentoring

[github-actions]

Deployed to https://pr-2005.aam-digital.net/

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[TheSlimvReal]

I am not sure that I can reproduce the bug. When I use the latest master, I can also enter or select a date range in the future.

[sleidig]

hmm, interesting. In the demo I can't reproduce either @TheSlimvReal . But here and in a client system it is happening: https://qm.aam-digital.com/matching (maybe due to synced mode or because the "end" field is not part of the form?)

[TheSlimvReal]

@sleidig I think you can reproduce it in the demo. The actual fix to the problem has not yet been deployed (#1988) With the "All" filter option it is also possible to only have a start or end date.

[sleidig]

@TheSlimvReal , indeed this bug only occurs if the "end" field is not part of the confirmation popup of the matching view.

[TheSlimvReal]

It seems like moment has a different behaviour depending on whether undefined or null is passed as end date.

[sleidig]

It seems like moment has a different behaviour depending on whether undefined or null is passed as end date.

ah, that makes sense, I guess.
I'd suggest to go ahead with this PR though, as the fix makes the behavior more explicit and reliable instead of using a not very well known default of moment.js

[aam-digital-ci]

🎉 This PR is included in version 3.24.0-master.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[aam-digital-ci]

🎉 This PR is included in version 3.24.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀