Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 0 value is ignored #2015

Merged
merged 3 commits into from
Oct 2, 2023
Merged

fix: 0 value is ignored #2015

merged 3 commits into from
Oct 2, 2023

Conversation

TheSlimvReal
Copy link
Collaborator

closes: #2013

Visible/Frontend Changes

  • Number 0 is shown in view string component

@github-actions
Copy link

Deployed to https://pr-2015.aam-digital.net/

sleidig
sleidig requested changes Sep 29, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the test deployment I still see empty instead of "0" columns in the Health Check sub-table when saving "0".

sleidig
sleidig approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@sleidig sleidig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, my complaint is related but actually due to explicit checks in the other *DisplayComponents. Added there now.

@sleidig sleidig merged commit 63150d5 into master Oct 2, 2023
6 checks passed
@sleidig sleidig deleted the zero_percentage_fix branch October 2, 2023 13:56
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.24.1-master.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Oct 2, 2023
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.25.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sleidig sleidig sleidig approved these changes

Assignees
No one assigned
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DisplayNumber in table columns is showing empty instead of displaying "0" as a value
3 participants
@TheSlimvReal @aam-digital-ci @sleidig