Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added lint check for space after comma #2039

Merged
merged 5 commits into from
Nov 6, 2023
Merged

Conversation

rudresh
Copy link
Contributor

@rudresh rudresh commented Oct 18, 2023

Enhances eslint to check for a space after comma.

@github-actions
Copy link

Deployed to https://pr-2039.aam-digital.net/

@rudresh rudresh mentioned this pull request Oct 18, 2023
2 tasks
@rudresh rudresh requested a review from TheSlimvReal October 18, 2023 14:57
@sleidig
Copy link
Member

sleidig commented Oct 19, 2023

Thanks for looking into this, @rudresh ! I had assumed the eslint default rules automatically always apply (and "comma-spacing.after" supposedly is a default?), wasn't this how tslint used to work with standard rules, @TheSlimvReal? Or was that just prettier?

@sleidig
Copy link
Member

sleidig commented Oct 19, 2023

@TheSlimvReal I added full prettier formatting to be enforced by the lint check now. What do you think?

@sleidig sleidig marked this pull request as ready for review October 23, 2023 13:04
@sleidig sleidig merged commit 334f1d4 into master Nov 6, 2023
5 of 6 checks passed
@sleidig sleidig deleted the lint-check-for-comma branch November 6, 2023 13:26
sleidig added a commit that referenced this pull request Nov 7, 2023
all prettier rules are enforced by lint check now

---------

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0-master.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released on @master managed by CI (semantic-release) label Nov 8, 2023
sleidig added a commit that referenced this pull request Nov 8, 2023
all prettier rules are enforced by lint check now

---------

Co-authored-by: Sebastian Leidig <sebastian@aam-digital.com>
@aam-digital-ci
Copy link
Collaborator

🎉 This PR is included in version 3.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@aam-digital-ci aam-digital-ci added the released managed by CI (semantic-release) label Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @master managed by CI (semantic-release) released managed by CI (semantic-release)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants